Add function to parse analysis complete notification JSON #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ada Luong <adaluong@google.com>
|
Is this still required? |
|
@calebbrown do we need this code? |
|
Long term - yes, I think this is the right place for this. Marshal/Unmarshal logic best exists next to the struct itself (e.g. url.Parse). In this particularly case I am planning a small refactor in #651. So it's not critical to have this merged. Given the lack of unit tests we probably want to wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function makes it easier for downstream consumers (like package analysis) to parse the package analysis complete notification and identify the package being analysed.
Signed-off-by: Ada Luong adaluong@google.com